Closed cxz66666 closed 1 year ago
Merging #12 (7bfa01d) into master (da64a46) will decrease coverage by
0.24%
. The diff coverage is36.36%
.
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 62.19% 61.95% -0.24%
==========================================
Files 14 14
Lines 775 778 +3
==========================================
Hits 482 482
- Misses 232 236 +4
+ Partials 61 60 -1
Flag | Coverage Δ | |
---|---|---|
unittests | 61.95% <36.36%> (-0.24%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
option.go | 14.81% <ø> (ø) |
|
statute/auth.go | 67.34% <ø> (ø) |
|
statute/message.go | 66.66% <ø> (ø) |
|
statute/method.go | 73.52% <ø> (ø) |
|
handle.go | 46.02% <26.31%> (-0.59%) |
:arrow_down: |
bufferpool/pool.go | 100.00% <100.00%> (ø) |
|
server.go | 61.53% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
ping @thinkgos, any update?
@cxz66666 改成 net.Conn
是因为要使用 其它网络库么? 可以考虑用 userAssociateHandle
, 自定义一个解析 . 目前CI mac go1.15版本测试失败
@thinkgos
TestDNSResolver
中报错Attempt to use unknown class
,使用1.16 macos则可以跑通。或许您可以更新下ci的go版本 https://github.com/cxz66666/go-socks5/actions/runs/4172609361/jobs/7223925635@cxz66666 这样, 你把所有检查eof 的返回明确返回nil, 把go.mod 版本提到1.18, ci 提到 1.19和1.20
@thinkgos ok,稍后我会在此分支中更新
@cxz66666 感谢, 我顺便加了dependabot. 那个golangci-lint 可以不用太关心,我没有实时跟进这些规则.
net.UDPConn is not a good type because it implements lots of functions, e.g.: if dial call
gonet.DialUDP
and returns agonet.UDPConn
type, it will cause a type cast error! So change all thenet.UDPConn
types tonet.Conn
Add check EOF error in
io.Read
. Without it in most situations, it will cause infinite loops!