search

thingsboard / thingsboard-extensions

13 stars 23 forks source link

`EntityAliasFilter` is not part of `EntityFilters` #56

Open skewty opened 1 year ago

skewty commented 1 year ago

app/shared/models/alias.models.d.ts

export type EntityFilters = SingleEntityFilter & EntityListFilter & EntityNameFilter & EntityTypeFilter & StateEntityFilter & AssetTypeFilter & DeviceTypeFilter & EdgeTypeFilter & EntityViewFilter & RelationsQueryFilter & AssetSearchQueryFilter & DeviceSearchQueryFilter & EntityViewSearchQueryFilter & EntitySearchQueryFilter & EdgeSearchQueryFilter;

export interface EntityAliasFilter extends EntityFilters {
    type?: AliasFilterType;
    resolveMultiple?: boolean;
}

Notice that EntityAliasFilter is not part of EntityFilters. Is this correct?

skewty commented 11 months ago

I see some similar type cleanup slated for version 3.6.2 inclusion. Reference: https://github.com/thingsboard/thingsboard/pull/9010

Will this issue be fixed for 3.6.2 as well?