thingsboard / thingsboard-gateway

Open-source IoT Gateway - integrates devices connected to legacy and third-party systems with ThingsBoard IoT Platform using Modbus, CAN bus, BACnet, BLE, OPC-UA, MQTT, ODBC and REST protocols
https://thingsboard.io/docs/iot-gateway/what-is-iot-gateway/
Apache License 2.0
1.74k stars 844 forks source link

[BUG] #458

Closed abordbar closed 3 years ago

abordbar commented 3 years ago

Describe the bug

Hi Guys, The bug I have found is as the following, Support we have 3 modbus devices with address 1 , 2 , 3 on one bus and we have configure them in modbus-serial.json file with unitId 1,2,3. if these 3 devices are online, the gateway work properly but if any of them be switched off, the gateway doesn't send the data of others.

Connector name (If bug in the some connector): [e.g. OPC-UA Connector]

Error traceback (If available):

'deviceName'
Traceback (most recent call last):
  File "<input>", line 2, in <module>
KeyError: 'deviceName'

Versions (please complete the following information):

imbeacon commented 3 years ago

Hi @abordbar ,

Thank you for your interest in ThingsBoard IoT gateway and message. I think it was caused by holding on connecting to unavailable device, I have added fix into master branch, please try to install the version of the gateway from it and rerun with a changed Modbus connector.

abordbar commented 3 years ago

Thank you so much for your fast response and your efforts.