search

thingswebuilt / osod24_firmware

0 stars 0 forks source link

statemanager house keeping - DRYness of servo handling #22

Closed markmellors closed 9 months ago

markmellors commented 9 months ago

There's a lot of repetition around how the steering servos are handled in statemanager , in particular, how they're initialised and how they're disabled when a wheel isn't moving

robberwick commented 9 months ago

I think in particular we're talking about https://github.com/thingswebuilt/osod24_firmware/blob/main/libs%2Fstatemanager%2Fsrc%2Fstatemanager.cpp#L46 onwards - is that correct?

markmellors commented 9 months ago

yes, and I was thinking that https://github.com/thingswebuilt/osod24_firmware/blob/8d732d777120b27ca8d1045995420f2cbed474a7/libs/statemanager/src/statemanager.cpp#L19 onwards is repetitive

markmellors commented 9 months ago

addressed by PR#24