search

thinhkhang97 / react-native-viewport-detector

React Native library for detecting component visibility in the viewport.
27 stars 2 forks source link

ViewportDectetor Android children calculation is wrong #5

Open anthlasserre opened 8 months ago

anthlasserre commented 8 months ago

Hey @thinhkhang97 👋🏼 I have been facing an issue with Android. I don't know if this is because of my specific usage but the ViewportDetector wasn't able to retrieve the children view layout.

By passing collapsable={false} to the children everything seems to be working as expected.

https://reactnative.dev/docs/view#collapsable-android

Are you able to reproduce this issue on Android?

Thanks for your time

I'll raise another PR for that. But I'll need to update the other first and moving forward helping you improving the library.

thinhkhang97 commented 8 months ago

@anthlasserre I've just commented on your PR, please take a look on it