thinhvo0108 / react-paypal-express-checkout

React component that renders Paypal's express check out button
MIT License
107 stars 71 forks source link

Additional Props Request #17

Closed firefox7025 closed 6 years ago

firefox7025 commented 6 years ago

I would like to request a few additional props.

Mainly the only difficulty I have in implementation is the lack of title and description for items. Something like this perhaps?

<PaypalExpressBtn client={client} note={'Thanks for your patronage!'} description={'A large mallet'} name={'Loony Tunes Hammer'} currency={'USD'} total={this.state.value} onError={onError} onCancel={onCancel} onSuccess={onSuccess} />

macsplan commented 6 years ago

@firefox7025 looking thru the paypal-checkout code that this library uses I can't find a reference to title & description.

any ideas where to look?

https://github.com/paypal/paypal-checkout

firefox7025 commented 6 years ago

You are absolutely correct, I was still somewhat confused on some of the changes between their checkout.js and standard developer buttons. It seems such an odd thing to remove, in any case, I am closing this issue thank you for the time and effort you placed on research.