search

thinhvo0108 / react-paypal-express-checkout

React component that renders Paypal's express check out button
MIT License
107 stars 71 forks source link

Forking and building #5

Closed tfulton closed 7 years ago

tfulton commented 7 years ago

Hi Thinh,

I'm a developer at PayPal, and would like to fork and use your repo. Excuse my naiveté, but any way you could post local build instructions as you may know them?

Todd

thinhvo0108 commented 7 years ago

Hi Todd,

Thanks for your message! Please go ahead, just fork and use my repo, and please also feel free to send me pull requests if possible, too!

About the local build instruction, sorry I didn't get what you meant yet, can you read my tutorial, there are simple and full examples, is that what you need?

Thinh

tfulton commented 7 years ago

Hey! I've forked the repo and want to test out local changes as an npm dependency. My package.json:

  "dependencies": {
    ...
    "react-dom": "^15.5.4",
    "react-paypal-express-checkout":
"file:../../react-paypal-express-checkout",
    ...
  },

For the build of the ./dist/ files in your project, I've tried npm prepublish but, my version of npm complains its deprecated. THIS is the part I was trying to get your help on. Not a big deal, really.

Nice work btw! Its really the only react example of PayPal checkout that seems to exist!!!! And I work at the place!!

Todd

On Tue, Jul 11, 2017 at 10:33 AM Thinh Vo notifications@github.com wrote:

Hi Todd,

Thanks for your message! Please go ahead, just fork and use my repo, and please also feel free to send me pull requests if possible, too!

About the local build instruction, sorry I didn't get what you meant yet, can you read my tutorial, there are simple and full examples, is that what you need?

Thinh

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thinhvo0108/react-paypal-express-checkout/issues/5#issuecomment-314517043, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAuvi1_ArsL_pbRhKlAkz0lBNosvkCiks5sM7H5gaJpZM4OUjZB .

thinhvo0108 commented 7 years ago

Hi @tfulton Todd,

I was busy lately, have you got this work yet in your local environment?

tfulton commented 7 years ago

Yes, I did. It works great. Thanks!!

On Tue, Oct 3, 2017 at 11:00 PM Thinh Vo notifications@github.com wrote:

Hi Todd,

I was busy lately, have you got this work yet in your local environment?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thinhvo0108/react-paypal-express-checkout/issues/5#issuecomment-334057678, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAuvn2StHjYK6fmw_t5GnSeu1WvgTz3ks5sox8ZgaJpZM4OUjZB .

thinhvo0108 commented 7 years ago

Thanks for your reply! Glad you had it working! I will close this ticket, then!