thinkaurelius / titan

Distributed Graph Database
http://titandb.io
Apache License 2.0
5.24k stars 1.01k forks source link

Add deep profiling information #1035

Closed mbroecheler closed 9 years ago

mbroecheler commented 9 years ago

by extending the profile step functionality added in TP3 M8 with information on index hits, cache performance, etc. With @rjbriody

rjbriody commented 9 years ago

@mbroecheler, some notes on expected usage of the TinkerPop Metrics framework:

The metrics for the Traversal Steps are created automatically and held/managed by the StandardTraversalMetrics class.

In Titan, an individual step's MutableMetrics can be augmented by

I think it makes sense for Titan to populate 2 separate nested metrics; one for index access and one for DB access. Each of these can annotated to describe index coverage.

mbroecheler commented 9 years ago

Temporarily blocked on https://issues.apache.org/jira/browse/TINKERPOP3-651

mbroecheler commented 9 years ago

This has been implemented under the assumption that Titan's custom steps can get access to a @MutableMetrics@ object. Hence, hooking this up with the work @rjbriody is doing in TP3 should be trivial. Once that is complete, this feature needs to be documented.

mbroecheler commented 9 years ago

This has been added on the titan09 branch. @rjbriody Please test and let us know whether the information comes through. I the information can be retrieved through TP3 this issue can be closed.

mbroecheler commented 9 years ago

@rjbriody Titan's profiling information has been flattened - i.e. no more AND/OR nesting. In addition, an optimization sub-metric has been added to measure the time taken by query optimization.

rjbriody commented 9 years ago

Cool. I will check it out.

On Tue, May 19, 2015 at 7:00 PM, Matthias Broecheler < notifications@github.com> wrote:

@rjbriody https://github.com/rjbriody Titan's profiling information has been flattened - i.e. no more AND/OR nesting. In addition, an optimization sub-metric has been added to measure the time taken by query optimization.

— Reply to this email directly or view it on GitHub https://github.com/thinkaurelius/titan/issues/1035#issuecomment-103692382 .

mbroecheler commented 9 years ago

@rjbriody Happy with it? If not, please reopen.