search

thinkaurelius / titan

Distributed Graph Database
http://titandb.io
Apache License 2.0
5.25k stars 1.01k forks source link

Check that titan-core no longer uses shaded kryo and trim pom.xml cruft #1155

Open dalaro opened 9 years ago

dalaro commented 9 years ago

titan-core/pom.xml on titan09 contains a shade-plugin configuration stanza to shade and relocate Kryo 2.24 and its dependencies. I think this is no longer needed, since titan09 doesn't directly depend on Kryo anymore. I also don't see any of the classfiles matching the post-shade patterns in titan-core.jar. So, it's my impression that the shade-plugin execution on titan-core is currently a noop.

Check that this is the case, then remove the shade plugin execution. We may need it again later for Guava (#1139), but it's easy to find in the git history when/if needed for future reference.

graben1437 commented 8 years ago

Dan, is the pom.xml content in question found in titan-core pom.xml between:

shade-gremlin-groovy

? If so, do you want me to go ahead and submit a pull request for this to remove this section (the entire shade section it would appear) from the pom.xml ? I will submit on the tp3-ci-31 branch.

dalaro commented 8 years ago

By the time I've refamiliarized with the pom section in question to the extent that I can confidently show that it's unused (and answer your question), deleting it will probably be quick. I'll take a look.