Improvements - Githubissues

thinker3197 / progressively

A JavaScript library to load images progressively 🌇

https://thinker3197.github.io/progressively

MIT License

698 stars 68 forks source link

Improvements #14

Closed thiamsantos closed 7 years ago

thiamsantos commented 7 years ago

Changelog:

Add visual test.
Use rollup-plugin-postcss to compile the css file and insert to head. So the user does not need to manually reference the css file.
Add script to easily see the gzip size of the project. Current size: 1.02kB.

thinker3197 commented 7 years ago

This looks good, but we can't simply deprecate the usage of progressively.css file as the users with who want will update the current semantic of the library will get errors. I personally want this change, and we can probably halt this for next major release. Great work though @thiamsantos!

thiamsantos commented 7 years ago

This looks good, but we can't simply deprecate the usage of progressively.css file as the users with who want will update the current semantic of the library will get errors.

You are completely right.

I personally want this change, and we can probably halt this for next major release.

So I will close this PR and open an issue to discuss the changes for v2. I have a lot of ideas and would be great see what do you think about that.