thinkinglabs / toggl-google-sheet

Import Toggl time entries into a Google Sheet
MIT License
20 stars 5 forks source link

Request for code review #16

Closed tdpauw closed 4 years ago

tdpauw commented 4 years ago

The intend of this PR is to collect code review suggestions.

This codebase started as a pure hack. All of a sudden people started asking for functional improvements. I didn't have the bandwidth to add the improvements.

On each request, I dug into the code and explained to the requester how they could implement the improvement. Each time, I obviously had a hard time digging back into the code as it was not readable at all.

With the last request, I was fed up digging back into the codebase. I decided to transform the codebase into a hexagonal architecture with tests. Now, I should be able to add additional requested timesheet formats like timesheets that include the project, description, user, ....

This is now the result of that transformation. I'm not particularly happy about the rendering implementation.

The codebase is ES6 based, but still has leftovers from ES5.

Any feedback is welcome. Thank you for your time!