thinkingmachines / geomancer

Automated feature engineering for geospatial data
MIT License
216 stars 16 forks source link

Explore QueryBuilder using SQLAlchemy PostGIS #7

Closed ljvmiranda921 closed 5 years ago

ljvmiranda921 commented 5 years ago

Let's remove the need for writing strings and formatting them. We need a more flexible API for building queries. Advantages:

PR Requirements

I suggest creating a query() method and have it an abstract class method. Must raise a NotImplementedError for geomancer.base.Spell. The geomancer.base.Spell.cast() method should ideally be inherited (all subclasses should just call super())

Ideal Scenario: when implementing a new Spell (i.e., subclassing the Spell base), I don't need to think of implementing cast anymore (in fact, this whole thing should be inherited, super()). Instead, I should just implement the query() method using the SQLAlchemy dialect.

ljvmiranda921 commented 5 years ago

Updated the description cc: @marksteve

jonzarecki commented 5 years ago

So no PostGIS support yet?