thinkingmachines / geowrangler

🌏 A python package for wrangling geospatial datasets
https://geowrangler.thinkingmachin.es/
MIT License
47 stars 14 forks source link

Updates to DEVELOPMENT.md #232

Closed tm-jc-nacpil closed 2 months ago

tm-jc-nacpil commented 2 months ago

I noticed that in the contributing section, the paragraphs are enclosed in code blocks but the actual code lines are not. This seems to stem from a stray ``` before the actual codeblocks See line:

https://github.com/thinkingmachines/geowrangler/blob/1cfb0d1ea7774896b897de87670bea85c4b65225/DEVELOPMENT.md?plain=1#L36

This makes the content confusing to read when reading the rendered markdown.

tm-jc-nacpil commented 2 months ago

Adding to this, the command nbdev_install_git_hooks is not working. From the nbdev_help, I think this should be nbdev_install_hooks instead?

butchtm commented 2 months ago

@tm-jc-nacpil yes the new command is nbdev_install_hooks in nbdev2. Fixed this issue in #234

joshuacortez commented 1 month ago

I think we forgot to change nbdev_install_hooks in the new DEVELOPMENT markdown in #234 . Will file a separate PR