thinkingmachines / geowrangler

🌏 A python package for wrangling geospatial datasets
https://geowrangler.thinkingmachin.es/
MIT License
47 stars 14 forks source link

Exactextract Tutorial #241

Closed tm-jc-nacpil closed 1 month ago

tm-jc-nacpil commented 1 month ago

Adds tutorial for exactextract zonal stats as a new section at the end of the current notebook

So far, I've written the ff.

  1. Replicating the same tutorial (adm1, grid AOIs, bing tile AOIs), just with exactextract
  2. A simple multiband example

Things I think we could add -- lmk your thoughts on this!

  1. Speed test between basic and exactextract functions
  2. Weighted statistics (technically supported by exactextract, but I haven't actually tried this yet, see: https://github.com/isciences/exactextract?tab=readme-ov-file#supported-statistics)
  3. include_cols and include_geoms params (I think not super needed since it's just changing the output table but not what's calculated)
review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

tm-danna-ang commented 1 month ago

Things I think we could add -- lmk your thoughts on this!

Hi @tm-jc-nacpil! Lgtm 😄 just wondering why the output wasn't save for Bing Tile Grid Tile AOIs (exactextract).

  1. Speed test between basic and exactextract functions

Sounds good! Maybe we can have a separate notebook for the benchmarking.

  1. Weighted statistics (technically supported by exactextract, but I haven't actually tried this yet, see: https://github.com/isciences/exactextract?tab=readme-ov-file#supported-statistics)

Not sure if other Geo are using weighted statistics so we can put this on low prio for now unless if you already have a use case for it.

  1. include_cols and include_geoms params (I think not super needed since it's just changing the output table but not what's calculated)

You can add a brief note in the tutorial notebook on how to use them or describe sample use cases.

tm-jc-nacpil commented 1 month ago

Latest commit adds the ff.!

tm-danna-ang commented 1 month ago

The tutorial looks great! 😄 Just have some alternate suggestions for a few parts.