Closed joshuacortez closed 1 month ago
hi @joshuacortez -- our original rationale was that unlike the other dataset related modules -- this module not actually about downloading the dhs data, but for manipulating DHS data -- unlike the other datasets, DHS data is not available publicly so we cannot provide utils for downloading it but instead each user must request it from the source.
The utilities provided are for massaging the provided data in such a way as to make it easier to manage for downstream activities such as building training/validation data for ML models.
Despite this, @tm-danna-ang @joshuacortez @tm-jc-nacpil feel free to chime if you feel strongly that it would be better to leave it stand alone or moved to the datasets module.
Thanks for explaining the rationale @butchtm !
I don't feel super strongly about it, but just thought that dataset-specific scripts (regardless of its just for download or also for manipulation) are together in the same directory
Curious to hear others' thoughts
I also don't have strong feelings about it but I think better to keep it as is just in case it's being used by UNICEF/EAPRO -- changing the location will affect the import step and might break existing notebooks
ok let's keep it as is then!
The dhs.py script seems out of place since it's not in the
datasets
subdirectory along withgeofabrik.py
,nightlights.py
, andookla.py
. Might be good to move its location