search

thinkingmachines / linksight-2018

LinkSight is a web app for applying the Philippine Standard Geographic Code to messy and misspelled barangay, municipality, city, and province names.
https://linksight.thinkingmachin.es
GNU General Public License v3.0
11 stars 1 forks source link

Properly differentiate exact, multiple and zero matches #116

Closed marksteve closed 6 years ago

marksteve commented 6 years ago

Addresses #106

No matches count

Also fixes substring checks which bumps the speed quite a bit! @piafaustino

marksteve commented 6 years ago

Yeah. It could be 2 columns. exact_match and matched. Current state looks dirty

On Tue, 14 Aug 2018, 11:03 PM Pia Faustino, notifications@github.com wrote:

@piafaustino commented on this pull request.

In app/src/check.js https://github.com/thinkingmachines/linksight/pull/116#discussion_r209987391 :

@@ -46,7 +46,7 @@ class Check extends React.Component { nestItems (items) { let prevIndex = null return items.reduce((matchItems, item) => {

  • if (item.matched === 'True') {
  • if (item.matched === 'True' || item.matched === null) {

Maybe we should eventually change the name of this from "matched" to "exact_match"

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/thinkingmachines/linksight/pull/116#pullrequestreview-146108676, or mute the thread https://github.com/notifications/unsubscribe-auth/AABoN0AQS-UHqwBwWHAduQsBY2r60z8oks5uQubSgaJpZM4V8Wpb .