search

thinkingmachines / linksight-2018

LinkSight is a web app for applying the Philippine Standard Geographic Code to messy and misspelled barangay, municipality, city, and province names.
https://linksight.thinkingmachin.es
GNU General Public License v3.0
11 stars 1 forks source link

Set all column datatypes to string in export dataframe #155

Closed marksteve closed 6 years ago

marksteve commented 6 years ago

Right now column datatypes are auto-detected and truncates some number-like columns (such as the PSGC). Set all column datatypes to string to keep source to export lossless. This only applies to CSV exports w/c is the only export type right now (See #153)

piafaustino commented 6 years ago

@marksteve new bug: Blank or unmatched PSG codes now appear in the exported dataset as the string "nan." They should instead be an empty string or null.

marksteve commented 6 years ago

@piafaustino can you attach the dataset you tried here? Let's do this for all matcher related issues!

piafaustino commented 6 years ago

@marksteve here we are! reg-onglao-test-matched_cKzIPz6.csv.zip

marksteve commented 6 years ago

Related: https://sentry.thinkingmachin.es/thinking-machines/linksight/issues/625/?referrer=slack

piafaustino commented 6 years ago

Closing because "nan" no longer appears as a value in the PSGC column