search

thinkingmachines / linksight-2018

LinkSight is a web app for applying the Philippine Standard Geographic Code to messy and misspelled barangay, municipality, city, and province names.
https://linksight.thinkingmachin.es
GNU General Public License v3.0
11 stars 1 forks source link

"Switch to a Desktop Device" appears even when using Desktop #161

Closed danidalisay closed 6 years ago

danidalisay commented 6 years ago

image

piafaustino commented 6 years ago

@daniellegayares what browser were you using when this happened?

danidalisay commented 6 years ago

Google Chrome

marksteve commented 6 years ago

@piafaustino This was done on purpose. It's hard to pick out if a browser is mobile or not cos there's no standard header defining it. This is usually done by checking the user-agent but you need to maintain an ever changing list of rules to determine if a browser is mobile so this method is a bit fragile. I opted to checking the viewport size instead since it is the actual constraint we're trying to impose (i.e. the interface doesn't look good on small screens) and not being "mobile" per se. Thoughts?

piafaustino commented 6 years ago

Ok this is fine -- @daniellegayares was your screen tiny when you were accessing Linksight? I tried resizing my browser manually and never saw this happen

danidalisay commented 6 years ago

Yes it happens when browser not on full screen

piafaustino commented 6 years ago

Unable to reproduce. Closing for now