search

thinkingmachines / linksight-2018

LinkSight is a web app for applying the Philippine Standard Geographic Code to messy and misspelled barangay, municipality, city, and province names.
https://linksight.thinkingmachin.es
GNU General Public License v3.0
11 stars 1 forks source link

No error shows up when uploading large size CSV files #197

Closed danidalisay closed 6 years ago

danidalisay commented 6 years ago

Using csv file with more than 3k rows:

Upload freezes on csv with >3k rows, no error shows up

image

image

When cut into 4k, works properly

image

marksteve commented 6 years ago

@syk0saje @daniellegayares This happens because of nginx. And since nginx throws the error, it's not a valid json response w/c is what filepond is expecting (because of the error handler I added). Filepond is most probably encountering this as an error and since it's within the error handler, it just gets stuck.

ghost commented 6 years ago

@marksteve what do you think of using this to set a client-side limit: https://github.com/pqina/filepond-plugin-file-validate-size

we just have to make sure it's equal to or smaller than the limit on nginx