search

thinkingmachines / linksight-2018

LinkSight is a web app for applying the Philippine Standard Geographic Code to messy and misspelled barangay, municipality, city, and province names.
https://linksight.thinkingmachin.es
GNU General Public License v3.0
11 stars 1 forks source link

Add suffix on the exact_matches join #244

Closed stuckoverflo closed 6 years ago

stuckoverflo commented 6 years ago

To reproduce: Run a dataset that has a field whose name is in any of the following:

['loc_tuple', 'code', 'matched_barangay', 'matched_city_municipality',
       'matched_province', 'reg']
marksteve commented 6 years ago

@florobarotjr row.get will return None when there's a clash

marksteve commented 6 years ago

@florobarotjr PING

stuckoverflo commented 6 years ago

@marksteve, made some changes to fix this inside the matcher. However, we'll still face the same issue on the final join (at the check part). If the client dataset has any of matched_*, code, and total_score in their dataset fields, they will be renamed to *_linksight since we have that part.

Hmm, still thinking of what the best approach here to deal with column names :/

stuckoverflo commented 6 years ago

Rebased and set to point to master. Will continue working on this