search

thinkingmachines / linksight-2018

LinkSight is a web app for applying the Philippine Standard Geographic Code to messy and misspelled barangay, municipality, city, and province names.
https://linksight.thinkingmachin.es
GNU General Public License v3.0
11 stars 1 forks source link

Fix/bugs in exported dataset #291

Closed stuckoverflo closed 5 years ago

stuckoverflo commented 6 years ago

For the first two items in #276

Added fix for #302

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 103

Changes Missing Coverage Covered Lines Changed/Added Lines %
linksight/api/models.py 8 12 66.67%
<!-- Total: 41 45 91.11% -->
Totals Coverage Status
Change from base Build 94: 2.8%
Covered Lines: 647
Relevant Lines: 768
💛 - Coveralls
marksteve commented 5 years ago

@florobarotjr can you add tests for the last 2 cases?

stuckoverflo commented 5 years ago

@marksteve, are you planning to merge #298 soon? I can rebase this branch after those changes have been merged and add the models-related tests.

marksteve commented 5 years ago

@florobarotjr I just updated the branch! Waiting for tests to finish then will merge.

marksteve commented 5 years ago

@florobarotjr merged #298

stuckoverflo commented 5 years ago

@marksteve oks! Will rebase and add tests!