thinkingmachines / unicef-ai4d-poverty-mapping

UNICEF AI4D Relative Wealth Mapping Project - datasets, models, and scripts for building relative wealth estimation models across Southeast Asia (SEA)
https://thinkingmachines.github.io/unicef-ai4d-poverty-mapping
MIT License
20 stars 8 forks source link

Indonesia Rollout Update #177

Closed tm-jc-nacpil closed 1 year ago

tm-jc-nacpil commented 1 year ago

This notebook updates the Indonesia rollout output and comparison

Changes

Results

image

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

alronlam commented on 2023-03-24T07:03:30Z ----------------------------------------------------------------

Line #1.    aoi_data = gpd.read_file(f'{rollout_date}-{country_code}-rollout-features.geojson')

Would recommend to revert the notebook to be completely runnable from top to bottom without relying on loading data from intermediate files.


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

alronlam commented on 2023-03-24T07:03:31Z ----------------------------------------------------------------

Line #3.    q_decimal = q / 100

Since we decided not to do this anymore, would recommend just deleting these quantile configs to reeduce complexity.


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

alronlam commented on 2023-03-24T07:03:32Z ----------------------------------------------------------------

Line #4.        max_val = features[[col]].quantile(q_decimal)

Same comment re: quantile. Let's just remove it.


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

alronlam commented on 2023-03-24T07:03:33Z ----------------------------------------------------------------

Line #1.    # Uncomment this cell and run to save a local copy of the scaled features

Since you said uncomment, might want to make the code commented by default haha


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

alronlam commented on 2023-03-24T07:03:34Z ----------------------------------------------------------------

Please remove this whole part; our asset index does not directly relate to income and socio-economic class.


tm-jc-nacpil commented on 2023-03-24T07:25:04Z ----------------------------------------------------------------

Hi alron, do you mean removing even the binning step entirely or just the markdown explanation?

alronlam commented on 2023-03-24T08:35:59Z ----------------------------------------------------------------

I meant just the markdown explanation (and the split-quintile parts). But retain the quintiles.