Pytest + Geopandas not in requirements

thinkingmachines / unicef-ai4d-poverty-mapping

UNICEF AI4D Relative Wealth Mapping Project - datasets, models, and scripts for building relative wealth estimation models across Southeast Asia (SEA)

https://thinkingmachines.github.io/unicef-ai4d-poverty-mapping

MIT License

20 stars 8 forks source link

Pytest + Geopandas not in requirements #185

Closed AnthonyMockler closed 1 year ago

AnthonyMockler commented 1 year ago

Trying to run the tests, followed the install instructions in readme, but when I run 'make test' it says make: pytest: No such file or directory make: *** [test] Error 1

Manually installing (via conda or pip) requirements-dev.txt resolves this.

Recommendation:

Update README to include the workflow for installing dev requirements using conda / mamba
Add a CI step that includes running the provided setup workflow and making sure the tests run

alronlam commented 1 year ago

Verified as of merged PR: https://github.com/thinkingmachines/unicef-ai4d-poverty-mapping/pull/198 that the requirements were fixed (it is now streamlined to just follow one file; no more requirements-dev as this isn't prod software anyway).