Parametrize / automate `process_string` parameter in nightlights module - Githubissues

thinkingmachines / unicef-ai4d-poverty-mapping

UNICEF AI4D Relative Wealth Mapping Project - datasets, models, and scripts for building relative wealth estimation models across Southeast Asia (SEA)

https://thinkingmachines.github.io/unicef-ai4d-poverty-mapping

MIT License

20 stars 8 forks source link

Parametrize / automate `process_string` parameter in nightlights module #77

Closed tm-jc-nacpil closed 1 year ago

tm-jc-nacpil commented 1 year ago

Hi @butchtm , just wanted to flag for future improvements. I have a feeling the process_suffix will change depending if they have changes in the preprocessing stages. It's possible that they will upload new versions, with a different process_suffix. In that case, since it's hardcoded, we might not find the correct url.

Possible Solution

could we parametrize make_url to accept a custom process_string ?

_Originally posted by @tm-jc-nacpil in https://github.com/thinkingmachines/unicef-ai4d-poverty-mapping/pull/75#discussion_r1070847302_

butchtm commented 1 year ago

implement as per request!

alronlam commented 1 year ago

Closing as this has already been implemented: https://github.com/thinkingmachines/unicef-ai4d-poverty-mapping/blob/main/povertymapping/nightlights.py#L286