thinkingrock-gtd / tr-pc

ThinkingRock for Personal Computers. Built on the Netbeans Platform.
https://trgtd.com.au
GNU General Public License v3.0
18 stars 13 forks source link

Java not found after installation on Windows as a runtime #143

Open RadekCap opened 4 months ago

RadekCap commented 4 months ago

After installation on Windows from MSI package application fails when there is no Java installed which is correct:

image

After the latest installation of JDK (currently 21) the error message remains.

java -version
openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Temurin-21.0.3+9 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode, sharing)

We have to let users what to do.

ursjoss commented 4 months ago

@RadekCap I'm running TR with Java 21 on Linux successfully, but will check again on windows.

From where was the installer built with which you face this issue?

RadekCap commented 4 months ago

Well, so it's the configuration issue. jdkhome isn't defined in trgtd.conf.

This line there fix the issue but user doesn't have a chance to know what to do:

jdkhome="C:\Program Files\RedHat\java-17-openjdk-17.0.11.0.9-1"

It's no big deal as the workaround is easy but I would let this open till we'll found some user friendly solution.

RadekCap commented 4 months ago

On Linux is detection working properly:

./trgtd-linux.sh 
Configuring the installer...
Searching for JVM on the system...
Java SE Development Kit (JDK) was not found on this computer
JDK 7 is required for installing ThinkingRock. Make sure that the JDK is properly installed and run installer again.
You can specify valid JDK location using --javahome installer argument.
ursjoss commented 4 months ago

JDK 7 is required for installing ThinkingRock

We have to work on the feedback though :-)

ursjoss commented 4 months ago

JDK 7 is required for installing ThinkingRock

We have to work on the feedback though :-)

Looks like that's the minimum JRE version required to run the installer. Not related to the JRE we need to run ThinkingRock.