thinkingrock-gtd / tr-pc

ThinkingRock for Personal Computers. Built on the Netbeans Platform.
https://trgtd.com.au
GNU General Public License v3.0
18 stars 13 forks source link

Windows - application icon is probably missing #144

Open RadekCap opened 4 months ago

RadekCap commented 4 months ago

After installation from MSI, there is this icon in the system menu:

image

This icon is probably default.

The application icon in the tray is correct one:

image

Tested on Windows 11.

ursjoss commented 4 months ago

~Possibly a duplicate of #81~

ursjoss commented 4 months ago

https://netbeans.apache.org/wiki/main/wiki/DevFaqExecutableIcon/

ursjoss commented 4 months ago

Option: Use rcedit to set icon (needs a windows machine, alternatively a linux machine with wine installed). Command to exchange the icon:

RCEDIT.EXE your_installer.exe /I icon_file.ico

Could be run in a github action job step, executing rcedit as shown above or optionally using a dedicated action: https://github.com/Bioblaze/rcedit-action.

In order to integrate it into the ant build:

<target name="replace-windows-icon" depends="build-launchers">
    <exec executable="RCEDIT.EXE" dir=".">
        <arg line="build\launcher\bin\${app.name}.exe /I branding\core\core.jar\org\netbeans\core\startup\${app.name}.ico"/>
    </exec>
</target>

Alternative to RCEdit, ReplaceVistaIcon.exe.

<target name="replace-windows-icon" depends="build-launchers">
    <exec executable="ReplaceVistaIcon.exe" dir=".">
        <arg line="build\launcher\bin\${app.name}.exe branding\core\core.jar\org\netbeans\core\startup\${app.name}.ico"/>
    </exec>
</target>