Closed ursjoss closed 1 year ago
my naive comment is: maybe this could be related to #44 ? I mean: maybe there's some operation that do the pruning of unused modules, like is the tree shaking in the js framework...only an idea
By removing cluster ide
, most of the excess plugins are gone. I also deactivated some modules from the platform
cluster (e.g. test libraries), thus decreasing the size of the installer and thus the installed set of files. Both topics should be revisited in #44.
I would close this as fixed by #57.
The solution presented here did fix the issue reported, but it also had an ugly regression: It broke the build (see #98) without our CI being sensitive to this kind of breakage and report it with a failing build. (That will be improved in the context of #99).
With ticket #98, we revert the PR from this ticket - therefore I'm re-opening this ticket to be solved w/o the regression after #98 and #99 have been resolved.
Current status after #112
This is the error message, after a first application run, tested on MacOS. There are no detected issues during usage of application after clicking "disable modules" during the first run.
Warning - could not install some modules: Diff - The module named org.netbeans.modules.editor.fold/1 was needed and not found. Diff - The module named org.netbeans.modules.editor.settings/1 was needed and not found. Diff - The module named org.netbeans.modules.editor.lib2/1 was needed and not found. Diff - The module named org.netbeans.modules.options.editor/1 was needed and not found. Diff - The module named org.netbeans.modules.editor.util/1 was needed and not found. Diff - The module named org.netbeans.modules.editor.document was needed and not found. Diff - The module named org.netbeans.modules.editor.errorstripe/2 was needed and not found. Diff - The module named org.netbeans.modules.editor.lib/3 was needed and not found. Diff - The module named org.netbeans.modules.projectapi/1 was needed and not found. Multi-tabs project bridge - The module named org.netbeans.modules.projectuiapi.base/1 was needed and not found. Multi-tabs project bridge - The module named org.netbeans.modules.projectapi/1 was needed and not found.
@RadekCap I couldn't really reproduce this on my machine. But hopfeully, PR #57 resolves this for you as well.
It's still there on both Mac and Linux. I'm attaching a screenshot from Linux.
Could it be the cache? On Linux I have it broken and it couldn't run from the ZIP package because it still uses java 11. When it runs from Netbeans, it's ok. I removed .cache/trgtd/tr-4.0 and the issue still persists. Is there any other place where something is cached?
On my machines java is different - Temurin on Mac, RH build on Linux. Netbeans is the same - 17.
The list of modules loaded in ThinkingRock-3.7.0 and that in the current development version differs considerably.
Modules loaded (according to log files)
Modules loaded in 3.7.0 (sorted w/o version indication)
Modules loaded in the developement version (sorted, w/o version indication)
Modules not loaded (according to log files)
Modules not loaded in the development version
Modules not loaded in the 3.7.0
Plugin Manager
This is most likely also reflected in the plugin manager. The Plugin-Manager in ThinkingRock (Menu
Tools
->Plugins
-> tabInstalled
) in the released version of ThinkingRock 3.7.0 only lists TR modules plus the library moduleext - commons-email
.In contrast, the development version lists many internal and NetBeans specific modules that should not be listed in the PluginManager:
We have to investigate the mechanics of such modules and how to prevent them from loading and/or showing in the plugin manager.
Out of scope
A follow-up task not tackled in the scope of this ticket: Modules can be auto-updated from a central ThinkingRock specific update-center. Version management for modules (the version of the modules, not the dependencies) will be very important once we start publishing updated modules to that update center. So far I have not paid any attention to this. This can be tackled in the future with ticket #58.