search

thinkle / gourmet

Gourmet Recipe Manager
GNU General Public License v2.0
337 stars 138 forks source link

Localized German units not recognized in MMF import #433

Closed ockham closed 11 years ago

ockham commented 11 years ago

Converted from SourceForge issue 1186032, submitted by SourceForge user hajo_schatz on 2005-04-19 15:14:11 UTC.

The German locale describes the 'comma' as the decimal separator, not the 'dot'. MMF-Files containing the 'comma' instead of the 'dot' in ingredient units will not show this ingredient after import.

ockham commented 11 years ago

Submitted by SourceForge user thomas_hinkle on 2005-04-22 23:34:46 UTC.

Logged In: YES user_id=1030390

Fixed in CVS -- tested & everything.

ockham commented 11 years ago

Submitted by SourceForge user thomas_hinkle on 2005-04-21 15:07:21 UTC.

Logged In: YES user_id=1030390

Okay, I believe I've fixed this in CVS. Could you attach or e-mail me a recipe that exhibits the problem so I can test? I tried hunting around for some German mealmaster recipes, but couldn't navegate any of the webpages I found well enough to download a proper mealmaster archive (since I don't speak German). I did find, incidentally, something called a REZKONV-Rezept archive. Is this something common in German? It looked like mealmaster files, but with all the field names translated (which is a bit of a PITA...)

Tom

ockham commented 11 years ago

Submitted by SourceForge user thomas_hinkle on 2005-04-20 20:42:26 UTC.

Logged In: YES user_id=1030390

Okay -- this sounds like two bugs:

  1. not recognizing localized decimal separators.
  2. Making ingredients disappear when we can't read the amount.

I'm working on a fix to both of them that should (as a side effect) also fix Gourmet's output of e.g. mealmaster files to properly follow the user's locale when ouputting decimals. A question: are thosuands separators at all common in e.g. German files? I don't know if units like 1.500 mL are at all common or if you'd always say 1,5 L. H

Here in the U.S. we use units which never could get near 1000 anything, so I haven't been worried about thousand separator characters for the most part. (if I have to worry about thousand separators, life is more complex since 1,500 would mean two different things depending on locale/context)

Tom