search

thinkle / gourmet

Gourmet Recipe Manager
GNU General Public License v2.0
339 stars 137 forks source link

mastercook mx2 categories are lost #544

Closed ockham closed 11 years ago

ockham commented 11 years ago

Converted from SourceForge issue 1533644, submitted by SourceForge user pgoembel on 2006-08-03 05:36:32 UTC.

When importing MasterCook mx2 (xml) files, the CatT (category) elements are ignored and therefore the information is lost.

Attached is a patch to fix this.

The patch also removes extra leading and trailing newlines from all the text.

The patch also adds Yield information to the instructions since there is no corresponding field in the gourmet database.

This patch stores the Yield info in the record dictionary and then deletes it after adding it to the instructions. That might not be the right way to do it.

ockham commented 11 years ago

Submitted by SourceForge user pgoembel on 2006-08-03 18:23:50 UTC.

Logged In: YES user_id=827222

Proposal 2 sounds better to me from a GUI perspective (keeping it less cluttered), although I suspect it could cause problems with the nutritional info calculations.

My main concern is helping a friend move from Windows98 to Linux. His concerns are being able to enter all his handwritten recipes without losing any information, and being able to print them out again on 5x3 inch recipe cards.

ockham commented 11 years ago

Submitted by SourceForge user thomas_hinkle on 2006-08-03 15:22:25 UTC.

Logged In: YES user_id=1030390

Thanks again! I've just implemented this patch.

I think long term Gourmet should do one of the following:

  1. Allow a "Yield" field in addition to a servings field.
  2. Allow a "Yield" field instead of a servings field (where the standard "unit" is "servings".

What do you think?

ockham commented 11 years ago

Submitted by SourceForge user pgoembel on 2006-08-03 06:11:57 UTC.

Logged In: YES user_id=827222

I should say yield has two attributes: quantity and units

ockham commented 11 years ago

Submitted by SourceForge user pgoembel on 2006-08-03 05:42:46 UTC.

Logged In: YES user_id=827222

A bread recipe might yield 4 loaves. Not sure how that converts to servings.

Also forgot to mention versions: this bug exists in both stable and unstable (I forget the numbers)

ockham commented 11 years ago

Submitted by SourceForge user thomas_hinkle on 2006-08-03 05:38:23 UTC.

Logged In: YES user_id=1030390

Is there a substantial difference between yield and servings?