martinp26 commented 4 years ago

Please consider pulling these smaller clean-ups, bugfixes, and a feature for the epub generator.

saxon-s commented 4 years ago

Thank you for submitting this pull request. I see you are a first time contributor. Welcome to Gourmet!

At this time we are actively migrating Gourmet to Python 3 and Gtk 3 at kirienko/gourmet. I'm therefore holding off merging minor PRs into thinkle/gourmet master for now.

A couple requests:

As requested on the Contributing Wiki Page stick to a one issue = one commit = one pull request policy. Split this PR up into three separate PRs.
As a general rule, don't change the code formatting (i.e. add or remove spaces, new lines, etc). Otherwise it makes it difficult to compare what has changed and if the change is necessary.
provide a brief description in your PR commit message why the change is necessary.
If you are fixing a bug please raise an issue ticket and reference the issue # in the PR

Adhering to the above will make the PR review smoother and the acceptance of the PR easier.

Thank you for your support.

martinp26 commented 4 years ago

Thanks for the feedback. I will split things up. Do you have a rough ETA for the Python 3 and Gtk 3 conversions?

Should I rather submit against kirienko/gourmet for the time being?

martinp26 commented 4 years ago

998

martinp26 commented 4 years ago

https://github.com/thinkle/gourmet/pull/999 https://github.com/thinkle/gourmet/pull/1000 https://github.com/thinkle/gourmet/pull/1002

thinkle / gourmet

Cleanup1 #997

998