thinknimble / tn-spa-bootstrapper

A production-ready Django SPA app on Heroku in 20 minutes or less!
https://tn-spa-bootstrapper-staging.herokuapp.com/
MIT License
8 stars 9 forks source link

[React - Vue] - Migrate E2E Tests from Cypress to Playwright #335

Closed noriega2112 closed 2 months ago

noriega2112 commented 2 months ago

What this does

Switches the E2E testing libraries from Cypress to Playwright for the React and Vue sides

Checklist

How to test

Add user steps to achieve desired functionality for this feature.

noriega2112 commented 2 months ago

The code looks good, but the Chrome and Firefox e2e tests have not passed yet:

image

Once these are passing and the conflict with main is resolved, this should be good to go!

@whusterj These checks shouldn't be showing as they were part of the cypress.yml github action that was before, I think they are still showing as they were required prior to opening the PR.

Now this is being handled on the playwright config file which makes the tests to run on the 3 major browsers.

whusterj commented 2 months ago

@whusterj These checks shouldn't be showing as they were part of the cypress.yml github action that was before, I think they are still showing as they were required prior to opening the PR.

Now this is being handled on the playwright config file which makes the tests to run on the 3 major browsers.

I see - that makes sense! They should disappear after we merge.