search

thinkpixellab / PxLoader

PxLoader is a simple JavasScript library for creating preloaders and resource downloaders for HTML5 apps.
http://thinkpixellab.com/pxloader
1.11k stars 173 forks source link

addCompletionListener callback parameter #17

Closed sprintstar closed 11 years ago

sprintstar commented 11 years ago

The documentation shows callbacks supplied to addCompletionListener get called with an event parameter, but it appears they don't. It would actually be useful if they did.

mplabs commented 11 years ago

I fixed this by adding e as a parameter to callback in PxLoader.js on line 85.

Lines 84 to 86 should be: if (e.completedCount === e.totalCount) { callback(e); }

joelfillmore commented 11 years ago

Sorry about the delay. Thanks @mplabs for the fix!