search

thinkpixellab / PxLoader

PxLoader is a simple JavasScript library for creating preloaders and resource downloaders for HTML5 apps.
http://thinkpixellab.com/pxloader
1.11k stars 173 forks source link

Ensure completion listeners fire after progress listeners (fixes #20) #50

Closed robinnorth closed 8 years ago

joelfillmore commented 8 years ago

@robinnorth - I merged your previous PR, can you resolve the conflicts with this one and update?

robinnorth commented 8 years ago

@joelfillmore - I've rebased my commits on master now, thanks for merging the previous PR. I wanted to make sure each was able to be merged separately, in case you didn't welcome a refactor 😉 . Once you've merged this, it might be worth tagging a new version and publishing a npm package update. I plan to investigate a tag-based PxLoaderScript plugin for JS files as part of my current project, but that might come later on...

joelfillmore commented 8 years ago

Thanks @robinnorth, I will publish a new npm version

robinnorth commented 8 years ago

Thanks @joelfillmore! Would you mind also updating the Bower package and adding a v1.1.0 tag to the commit so Bower and npm are kept in sync?

joelfillmore commented 8 years ago

Yes, done!

robinnorth commented 8 years ago

Thanks @joelfillmore! I can't see the tag in the repo tags list though, perhaps it hasn't pushed. Bower still sees v1.0.0 as being the latest version as a consequence.

joelfillmore commented 8 years ago

Took another look and realized I hadn't pushed the tags. Fixed now, thanks @robinnorth!

robinnorth commented 8 years ago

Nice one @joelfillmore, thanks for putting up with my persistent requests 😉 Can confirm Bower sees v1.1.0 as the latest version now 👍 🎉