search

thinkshout / robo-drupal

Robo commands and tasks for Drupal
GNU General Public License v3.0
6 stars 0 forks source link

#60 Ensure local config changes stay local #62

Closed bdimaggio closed 4 years ago

bdimaggio commented 4 years ago

Make our local config-split call to a config split called config_local rather than local.

bdimaggio commented 4 years ago

Hey @unclegcb or @maria-thinkshout, could one of you take a look at this? Details here. I'll happily make the corresponding changes in our drupal-project if this all makes sense.

mariacha commented 4 years ago

@bdimaggio Makes sense to me, but could we also go the other way and make the folder/settings.php changes in the drupal project reference "local"?

bdimaggio commented 4 years ago

@mariacha certainly. My reasoning for config_local that it might be a clearer folder name for devs encountering a project's git root for the first time (it'd have a clear relationship to the config dir they also see there), but I'm not picky.

mariacha commented 4 years ago

I like that logic and would agree with it, but the problem is with backwards compatibility. There are currently 18 projects using the "local" config name: https://github.com/search?q=org%3Athinkshout+config_split.config_split.local&type=Code

And the only freedom house is using config_local (excluding uchi, which I switched over at one point so it's using "both") https://github.com/search?q=org%3Athinkshout+config_split.config_split.config_local&type=Code

So it will cause a lot fewer headaches if we use local here and switch the robo drupal project folder name to "local".

bdimaggio commented 4 years ago

Ah! That makes sense. Okay, I'll do that work over in the robo repo, then.

mariacha commented 4 years ago

@bdimaggio bringing this one up again because it looks like if you're on Drupal 8.8, adding "devel" to the config_exclude_modules options also solves this. See this: https://github.com/thinkshout/encp-covid/commit/8eafc869bc1b0ab89893f306147dd237ef811448