Closed jamacon36 closed 2 years ago
This looks good to a quick review. To your point about line 447 of Otis_Importer, how do you feel about the performance impact of making a WP_Query for every single listing, as opposed to the old method of grouping UUIDs for a single query? Is the goal there to minimize the possibility of timeouts? @jamacon36
@BrendanAdkins exactly re: the for vs while loop, meta queries are notoriously slow and taxing so my thought was to reduce the size of the query to make the look up more efficient. I could be really on the wrong path but things seem happier
I'm wavering on this. It'd be one thing if we were replacing a meta query with a non-meta query, but this is breaking one big meta query into a series of smaller meta queries, and I don't have good insight into the performance impact there. Still, if it's working acceptably in production and not blocking site operations it's probably okay for now. I'll log an issue to compare performance when we have more time.
Overview
This reworks logging, replaces the giant query that happens in upserting POIs, and adds a date range field to the dashboard and supporting server logic.
Notes
This has been well tested and needs a look at the code to make sure it's sound and a check for things like forgotten console logs.
Locations of Note