search

thinkshout / wp-otis

WordPress plugin for the Oregon Tourism Information System
GNU General Public License v2.0
4 stars 1 forks source link

OTIS: Importer stops when POI not found #51

Closed mhull closed 3 weeks ago

mhull commented 6 months ago

I am having issues with the "Sync All Poi's" process not completing and getting stuck mid-sync. I realized that this line of code is what was keeping it from completing.

https://github.com/thinkshout/wp-otis/blob/a4d8ccff2c3a43e95afc17f9290f00a21cf49cdc/src/Otis_Importer.php#L366

It doesn't seem like a single POI going missing should abort the entire syncing process. As a workaround, I commented out the line of code and just did a return so that the rest of the POI's after the missing one could sync.

Is there a possibility that this can be addressed in a future version - that an error can be flagged or logged somehow without aborting the entire process? If so, that would be much appreciated!

aletamelton commented 6 months ago

@mhull We have added this issue to our next release.

mhull commented 6 months ago

Awesome, thank you so much!

mshaver commented 1 month ago

I believe this issue is fixed and will be in the next release of the OTIS plugin. Any further work needed here @BrendanJercich ?

BrendanJercich commented 1 month ago

@mshaver Nope, you are correct, this will be fixed in the release.

mshaver commented 3 weeks ago

Closing as included with latest release.