search

thinkst / canarytokens-docker

Docker configuration to quickly setup your own Canarytokens.
BSD 3-Clause "New" or "Revised" License
598 stars 110 forks source link

[BUG] Certbot ignores start.sh #180

Open Tahir-ShiftCTRL opened 3 weeks ago

Tahir-ShiftCTRL commented 3 weeks ago

Describe the bug When launching docker-compose-letsencrypt.yml, let's encrypt tries to get certs for domain.com and www.domain.com. If you modify start.sh and remove " -d www.${MY_DOMAIN_NAME}" from the _args, nothing changes. If I add --staging to the certbot line, nothing it still tries to issue a real cert. If I completely delete the start.sh file, nothing changes, it still tries to issue a real cert with the domain.com and www.domain.com

To Reproduce Steps to reproduce the behavior:

  1. delete start.sh
  2. run docker compose -f docker-compose-letsencrypt.yml up -d
  3. check docker logs nginx

Expected behavior Certs should not be issued

Desktop (please complete the following information):

jayjb commented 2 weeks ago

Hi @Tahir-ShiftCTRL,

Thanks for reporting this. I think I have an idea of what might be going wrong. Can you quickly confirm something for me - when you say delete start.sh, where are you deleting it?

The reason I ask is that if you are using the docker images (i.e. not building your own), then the docker image will contain the start.sh; if you have cloned the repo and run docker compose -f docker-compose-letsencrypt.yml up -d, then the start.sh that is being run, is the start.sh that is inside the docker container.

github-actions[bot] commented 3 days ago

This issue is stale because it has been open for 14 days with no activity.

jayjb commented 6 hours ago

Hi @Tahir-ShiftCTRL,

Please let me know about the above questions when you have a moment.