thinkst / canarytokens

Canarytokens helps track activity and actions on your network.
http://canarytokens.org
Other
1.75k stars 258 forks source link

Remove the trailing dot from a domain name if present. #568

Closed thinkst-francois closed 2 months ago

thinkst-francois commented 2 months ago

In RFC1034 a domain ends with a dot, this dot is stripped out by applications in most cases, but may be present. We remove this before comparing with the refering url.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

If it fixes a bug be sure to link to that issue. If it resolves a feature request, be sure to link to that discussion.

Types of changes

What types of changes does your code introduce to this repository? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...