Add src ip to canarydrop on token create - Githubissues

thinkst / canarytokens

Canarytokens helps track activity and actions on your network.

http://canarytokens.org

Other

1.76k stars 258 forks source link

Add src ip to canarydrop on token create #597

Closed thinkst-pieter closed 1 month ago

thinkst-pieter commented 1 month ago

Proposed changes

This adds the IP to the canarydrop from which the request came to create the canary token. Testing was also expanded to test for the headers.

The created_from_ip and created_from_ip_x_forwarded_for are optional as to not break existing tokens that do not already have the information.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update

Checklist

[x] Lint and unit tests pass locally with my changes (if applicable)
[x] I have run pre-commit (pre-commit in the repo)
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Linked to the relevant github issue or github discussion