search

thinkst / opencanary

Modular and decentralised honeypot
http://opencanary.org
BSD 3-Clause "New" or "Revised" License
2.27k stars 355 forks source link

Why was the RDP module removed? #240

Closed 1Stronk closed 1 year ago

1Stronk commented 1 year ago

Hello,

This tool is really neat, but I was wondering why the RDP module was removed? Is it because rdpy leverages outdated python libraries and seems to be abandoned? Or any other specific reason?

:)

HybridAU commented 1 year ago

@jayjb can probably give a better answer, but I think that's pretty much it;

rdpy only works with Python 2 which was end-of-lifed on the 1st of January 2020 (over 3 years ago at the time of this writing) and rdpy itself hasn't seen any serious development since 2015 (over 8 years ago).

A couple of years ago I looked for an RDP library that worked with Python 3 and found nothing, then I looked at the effort that would be required to port rdpy to Python 3, but that was a staggering amount of work.

It might be possible to write enough of an RDP implementation to listen on port 3389, capture login attempts and return failed for every request without implementing the full RDP spec. But even that I suspect would be a lot of work.

1Stronk commented 1 year ago

rdpy only works with Python 2 which was end-of-lifed on the 1st of January 2020 (over 3 years ago at the time of this writing) and rdpy itself hasn't seen any serious development since 2015 (over 8 years ago).

A couple of years ago I looked for an RDP library that worked with Python 3 and found nothing, then I looked at the effort that would be required to port rdpy to Python 3, but that was a staggering amount of work.

If its any help, I found this attempt of converting rdpy to python 3, but I cannot comment on its functionality: https://github.com/citronneur/rdpy/tree/python3

Thanks for elaborating tho!

Neleus commented 1 year ago

rdpy only works with Python 2 which was end-of-lifed on the 1st of January 2020 (over 3 years ago at the time of this writing) and rdpy itself hasn't seen any serious development since 2015 (over 8 years ago). A couple of years ago I looked for an RDP library that worked with Python 3 and found nothing, then I looked at the effort that would be required to port rdpy to Python 3, but that was a staggering amount of work.

If its any help, I found this attempt of converting rdpy to python 3, but I cannot comment on its functionality: https://github.com/citronneur/rdpy/tree/python3

Thanks for elaborating tho!

It's working with python2.7, but not with 3.X+

jayjb commented 1 year ago

@1Stronk and @Neleus, I've merged the awesome work @HybridAU did for an RDP module.