thinkst / opencanary

Modular and decentralised honeypot
http://opencanary.org
BSD 3-Clause "New" or "Revised" License
2.21k stars 353 forks source link

Fix regression in telnet service #321

Closed thinkst-francois closed 8 months ago

thinkst-francois commented 8 months ago

Proposed changes

A regression in the telnet service occured where the Realm/portal required by AuthenticatingTelnetProtocol in twisted was removed.

Types of changes

What types of changes does your code introduce to this repository? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

thinkst-francois commented 8 months ago

Local tests:

2023-10-30T13:28:26+0000 [twisted.internet.protocol.ServerFactory#info] Starting factory <twisted.internet.protocol.ServerFactory object at 0x7feced277430>
{"dst_host": "192.168.5.157", "dst_port": 23, "honeycred": false, "local_time": "2023-10-30 13:28:33.402619", "local_time_adjusted": "2023-10-30 13:28:33.402648", "logdata": {"PASSWORD": "passworcd", "USERNAME": "admin"}, "logtype": 6001, "node_id": "opencanary-1", "src_host": "192.168.5.99", "src_port": 33128, "utc_time": "2023-10-30 13:28:33.402644"}
{"dst_host": "192.168.5.157", "dst_port": 23, "honeycred": true, "local_time": "2023-10-30 13:28:36.283700", "local_time_adjusted": "2023-10-30 13:28:36.283772", "logdata": {"PASSWORD": "password", "USERNAME": "admin"}, "logtype": 6001, "node_id": "opencanary-1", "src_host": "192.168.5.99", "src_port": 33128, "utc_time": "2023-10-30 13:28:36.283766"}