Closed farmmanic closed 4 months ago
Hi @farmmanic
Thank you for your contribution. It seems the change in your PR is already present in our master branch so I'm closing this PR. Please feel free to open another PR if you'd like to contribute any other changes.
My bad i didn't have a ci/cd too chain for updating my fork.
On Fri, Mar 15, 2024, 9:52 AM gjcthinkst @.***> wrote:
Hi @farmmanic https://github.com/farmmanic
Thank you for your contribution. It seems the change in your PR is already present in our master branch so I'm closing this PR. Please feel free to open another PR if you'd like to contribute any other changes.
— Reply to this email directly, view it on GitHub https://github.com/thinkst/opencanary/pull/344#issuecomment-1999713670, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY3AXXQB3P5545RSUOSU6F3YYL4JXAVCNFSM6AAAAABEUOGWJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZG4YTGNRXGA . You are receiving this because you were mentioned.Message ID: @.***>
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug be sure to link to that issue. If it resolves a feature request, be sure to link to that discussion.
Types of changes
What types of changes does your code introduce to this repository? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.pre-commit
in the repo)Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...