thinkstack-co / terraform-modules

Terraform modules
MIT License
7 stars 4 forks source link

added region variable and argument to vpc module #140

Open stfusanguinette opened 1 year ago

zachreborn commented 1 year ago

If I may offer a suggestion @stfusanguinette , you probably don't/won't need this. The region always comes from the provider blocks. So if you're trying to make two VPCs in the same code repository you can just add a second provider with an alias.

Check out some of the backup repositories how that can be accomplished. You'll see there are two providers in main.tf set and they use aliases.

stfusanguinette commented 1 year ago

If I may offer a suggestion @stfusanguinette , you probably don't/won't need this. The region always comes from the provider blocks. So if you're trying to make two VPCs in the same code repository you can just add a second provider with an alias.

Check out some of the backup repositories how that can be accomplished. You'll see there are two providers in main.tf set and they use aliases.

@zachreborn Dude, hey, long time no talk! I was going the 2nd provider block route, but Sean wanted me to do it this way. Jake was out so he told me to just make the code and wait for Jake to get back. When Jake got back, we discussed that, yes, the 2nd provider block was the way to go. I'm pretty happy to know I was thinking correctly about this; thanks for confirmation! Hope you're well!