Closed pirog closed 4 years ago
@dustinleblanc @mikemilano i've tried to codify the updated format/goals for our standups and eow meeting. i will be merging this in friday but wanted to give both of you an opportunity to comment beforehand if there are any additions/suggestions you have.
Here are the relevant pages in the PR environment https://pr-126-fal46ma-txmhst4apts56.us-2.platformsh.site/guides/daily-standups.html https://pr-126-fal46ma-txmhst4apts56.us-2.platformsh.site/guides/eow-meeting.html
Worth pointing out that these are intentionally "high level" eg they try not to "hardcode" implementation details that very well could change in the future eg the times of said standups. I think that makes the most sense but certainly open to being wrong.
@pirog: once this is merged in make sure you update the google calendar invites to point to the relevant docs @dustinleblanc: once this is merged in it might be worth just surfacing it in slack or a standup so everyone can get eyes on it
@mikemilano @dustinleblanc im going to merge this in but still free to comment or open a new issue/pr if you think it requires changes
I just submitted code and now I want to make sure it's ready for primetime!!!
In order to do that I need to first go through the below checklist entitled "For Me" because I respect my coworkers and want to get this PR into the best place possible before i ask for their time. When i am done i will then summon reviewers for feedback and comment. These reviewers will have about a week to complete their review.
If they do not review in the time alloted or have no change requests or blocking concerns the person who opened the pull request will apply the "Ready to merge" label which will ping the Keepers of Faith to press the merge button.
For me
Bare minimum self-checks
master
Pieces of flare
Finally
For the reviewer
Acceptance Test
THE PERSON WHO SUBMITS THE PR SHOULD PUT THEIR ACCEPTANCE TEST HERE.
The acceptance test should detail the steps the reviewer can take to
Here is a very simple example you can follow
Steps to replicate
Fix
Reviewer checks
I've completed the following tasks and requested changes from the submitter if changes were needed before a :+1: could be given.
For the Keeper(s) of the Faith