Thiagospiff - Githubissues

thinktandem / tandem

All the things that power the Tandem engine

https://thinktandem.io/

4 stars 2 forks source link

Thiagospiff #257

Open reynoldsalec opened 3 years ago

reynoldsalec commented 3 years ago

Trying this here to see if the Platform PR build works.

reynoldsalec commented 3 years ago

Hey @thiagodemellobueno, glad to have you back on the scene!

Merged things over here because I was worried your cross-repo PR was causing P.sh build issues, but it turned out to just be linting fun 🙄

Let's chat about this, definitely some of our priorities have changed so we should reconnect around that and see what we want to do with the work in progress so far.

thiagodemellobueno commented 3 years ago

:+1: Linting has gotten really intense of late in our multi - language multi package world. Glad to chat at your convenience.

reynoldsalec commented 3 years ago

@thiagodemellobueno here are the items we discussed today when looking at the PR environment

[ ] Padding on the "Work" case studies.
[ ] Max width across the site needs to be constrained.
[ ] Background on the menu slider (it's currently transparent across the site)
[ ] Arrows on the home page slider.
[ ] Different hero styling between the /work page and the other pages (/about and /blog)
[ ] Menu hamburger isn't centered in the Tandem logo.
[ ] Line height issue on the bottom of the /about page ("Primarily remote.Primarily USA.Prone to wanderlust.")

I'd keep on the look-out for any other text inconsistencies.

thiagodemellobueno commented 3 years ago

Nav background is fine in Firefox (if you wanna preview). First chromium/firefox xbrowser bug I've seen in some time.

reynoldsalec commented 3 years ago

Couple things that are blocking merge right now (@thiagodemellobueno you're off the hook on these, appreciate you going the extra mile to clean up the other stuff, we can chat on Slack about setting you up with a budget to fix these up if you're interested).

Blog List Page

[ ] List view items are out-of-whack; see positioning of the author portrait (note this is also a problem on individual blog posts).
[ ] Go back to the big tags?
[ ] Link blog titles.

Blog Article Page

[ ] "Learn More About" tags list has black background. (very bottom of page)
[ ] Subscribe form needs attention (button sizing compared to form field)

Contact Page

[ ] Differences in the form button sizes/text style.