I just submitted code and now I want to make sure it's ready for primetime!!!
In order to do that I need to first go through the below checklist entitled "For Me" because I respect my coworkers and want to get this PR into the best place possible before i ask for their time. When i am done i will then summon reviewers for feedback and comment. These reviewers will have about a week to complete their review.
If they do not review in the time alloted or have no change requests or blocking concerns the person who opened the pull request will apply the "Ready to merge" label which will ping the Keepers of Faith to press the merge button.
[ ] I've gone into that issue and if it is a task with a linked "next task" i've gone into that task and made its next task or prompted a discussion there about what its next task should be
Pieces of flare
[ ] I've written a unit or functional test for my code
[ ] I've updated this repo's README if my code changes it
[ ] I've updated relevant documentation it my code changes it
I just submitted code and now I want to make sure it's ready for primetime!!!
In order to do that I need to first go through the below checklist entitled "For Me" because I respect my coworkers and want to get this PR into the best place possible before i ask for their time. When i am done i will then summon reviewers for feedback and comment. These reviewers will have about a week to complete their review.
If they do not review in the time alloted or have no change requests or blocking concerns the person who opened the pull request will apply the "Ready to merge" label which will ping the Keepers of Faith to press the merge button.
For me
Bare minimum self-checks
master
Pieces of flare
Finally
For the reviewer
Acceptance Test
THE PERSON WHO SUBMITS THE PR SHOULD PUT THEIR ACCEPTANCE TEST HERE.
The acceptance test should detail the steps the reviewer can take to
Here is a very simple example you can follow
Steps to replicate
Fix
Reviewer checks
I've completed the following tasks and requested changes from the submitter if changes were needed before a :+1: could be given.
For the Keeper(s) of the Faith