thinreports / thinreports-generator

A Ruby library for Thinreports
https://github.com/thinreports/thinreports
MIT License
297 stars 48 forks source link

Fix argument of Thinreports::Report.generate in Ruby 3.0 #116

Closed sada closed 2 years ago

sada commented 2 years ago

Summary

The sample code raised ArgumentError in Ruby 3.0.

Thinreports::Report.generate(filename: 'report.pdf', layout: 'report.tlf') do |report|
  report.start_new_page do |page|
    # :
  end
end

This PR changed argument of Thinreports::Report.generate.

Issue

https://github.com/thinreports/thinreports-generator/issues/115

sada commented 2 years ago

GitHub Actions failed. This failed test is other issue.

URL in the test is 404 page.

https://github.com/thinreports/thinreports-generator/blob/15657a3be091e5ccd8d3572cd52d76d43a2ad71e/test/features/image_block/test_feature.rb#L29

hidakatsuya commented 2 years ago

PRありがとうございます!

This failed test is other issue.

URL in the test is 404 page.

こちら、 https://github.com/thinreports/thinreports-generator/commit/38b3e5d34454d927c9c820c0590da626502abd9b でmaster を修正しましたので、すみませんが rebase をお願いします。

sada commented 2 years ago

@hidakatsuya 対応ありがとうございます。rebaseしました。

hidakatsuya commented 2 years ago

ご対応ありがとうごさいました!

sada commented 2 years ago

マージありがとうございます!