search

thinreports / thinreports-generator

A Ruby library for Thinreports
https://github.com/thinreports/thinreports
MIT License
294 stars 48 forks source link

Warnings of base64 and bigdecimal will no longer be part of Ruby 3.4.0 #133

Closed tnj closed 8 months ago

tnj commented 8 months ago

Running thireports-0.14.1 on Ruby 3.3.0 produces those warnings.

/bundle/ruby/3.3.0/gems/thinreports-0.14.1/lib/thinreports/basic_report/core/shape/text_block/formatter/number.rb:3: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of thinreports-0.14.1 to add bigdecimal into its gemspec.
/bundle/ruby/3.3.0/gems/thinreports-0.14.1/lib/thinreports/basic_report/generator/pdf/document/graphics/image.rb:4: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of thinreports-0.14.1 to add base64 into its gemspec.

Looks like adding bigdecimal and base64 to gemspec solves the issue.

hidakatsuya commented 8 months ago

Thank you for your report.That's true.

https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/

RubyGems and Bundler warn if users do require the following gems without adding them to Gemfile or gemspec. This is because they will become the bundled gems in the future version of Ruby. base64 bigdecimal

I'll fix it.