Fix Error Parsing to Support Chain Overrides

pajserb0y commented 4 months ago

Changes

Here is the problem being solved.
Try relaying concurrent transactions signed by the same wallet while on the same non-commercial chain, the UNPREDICTABLE_GAS Error gets triggered, and when parsing Error data the getChainByChainIdAsync gets called but it doesn't have info about custom chain override it errors which results in infinite looping of all transactions trying to process and never do
Here are the changes made.
errors.ts added check for chainOverrides

How this PR will be tested

[ ] Open the dashboard and click X. Result: Try relaying concurrent transactions signed by the same wallet on custom chain override

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)

PR-Codex overview

The focus of this PR is to enhance error handling and configuration retrieval in the errors.ts file.

Detailed summary

Added Chain import
Added getConfig import
Updated error handling logic to use configuration overrides
Improved error message readability

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

arcoraven commented 4 months ago

Hey there and thank you for the contribution! You're absolutely right that we aren't accounting for custom chain overrides in this error checker here.

Ideally we can abstract the chain resolver to a helper function instead since we'll likely want this "get chain from overrides or SDK" logic everywhere.

Is this actively blocking you right now? Are you able to delete the bad txs from the DB manually to unblock yourself?

pajserb0y commented 4 months ago

Hey,

Not not acively after the fix I haven’t had any more problems m, and yes I had to cancel manually the bad txns from DB, now everything that I am using seems to be working fine,

Best, Marko

On Tue, 18 Jun 2024 at 04:30, Phillip Ho @.***> wrote:

Hey there and thank you for the contribution! You're absolutely right that we aren't accounting for custom chain overrides in this error checker here.

Ideally we can abstract the chain resolver to a helper function instead since we'll likely want this "get chain from overrides or SDK" logic everywhere.

Is this actively blocking you right now? Are you able to delete the bad txs from the DB manually to unblock yourself?

— Reply to this email directly, view it on GitHub https://github.com/thirdweb-dev/engine/pull/546#issuecomment-2174834952, or unsubscribe https://github.com/notifications/unsubscribe-auth/APQG3NZIYS7HADAR3YIL4FLZH6LVXAVCNFSM6AAAAABJJ647DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZUHAZTIOJVGI . You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 4 months ago

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days.

thirdweb-dev / engine