thirdweb-dev / engine

The most powerful backend engine for web3 apps.
https://thirdweb.com/engine
Apache License 2.0
152 stars 59 forks source link

IP Allowlist #564

Closed d4mr closed 3 months ago

d4mr commented 4 months ago

Changes


PR-Codex overview

The focus of this PR is to enhance security features, update dependencies, and improve configurations.

Detailed summary

The following files were skipped due to too many changes: src/prisma/schema.prisma, src/tests/chain.test.ts, src/tests/auth.test.ts, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

farhanW3 commented 4 months ago

@d4mr

can we also add test-cases for this in auth.test.ts in src/tests.

socket-security[bot] commented 3 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/estree@1.0.5 None 0 25.7 kB types
npm/@vitest/coverage-v8@2.0.3 Transitive: environment, filesystem, shell +39 4.41 MB vitestbot
npm/@vitest/pretty-format@2.0.3 environment +1 53.7 kB vitestbot
npm/minipass@7.1.2 None 0 286 kB isaacs
npm/vitest@2.0.3 environment, eval Transitive: filesystem, network, shell, unsafe +81 278 MB vitestbot

🚮 Removed packages: npm/@babel/core@7.24.6, npm/@babel/generator@7.24.6, npm/@babel/helper-plugin-utils@7.24.6, npm/@babel/parser@7.24.6, npm/@babel/template@7.24.6, npm/@types/babel__traverse@7.20.6, npm/@types/istanbul-lib-coverage@2.0.6, npm/@types/jest@29.5.12, npm/expect@29.7.0, npm/jest-util@29.7.0, npm/jest@29.7.0, npm/pretty-format@29.7.0, npm/signal-exit@3.0.7, npm/ts-jest@29.1.4

View full report↗︎

socket-security[bot] commented 3 months ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/esbuild@0.21.5 🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/esbuild@0.21.5